As people have worked in other languages like Go which has strictly enforced automatic formatting, it has gained advocates. We’re trying to decide whether to require that code be formatted by clang-format before submitting to gerrit or to update the formatting automatically every once in a while.
Arguments for automatic formatting1. Submitters should run clang-format before submitting a patch and it should be rejected in gerrit if it’s not formatted properly with an error telling them how to format it. (Condorcet winner: wins contests with all other choices) |
2. coreboot should stick with manual formatting. loses to Submitters should run clang-format before submitting a patch and it should be rejected in gerrit if it’s not formatted properly with an error telling them how to format it. by 30–28 |
3. Code should just get automatically reformatted on a regular basis. loses to Submitters should run clang-format before submitting a patch and it should be rejected in gerrit if it’s not formatted properly with an error telling them how to format it. by 33–17, loses to coreboot should stick with manual formatting. by 29–26 |
For simplicity, some details of the poll result are not shown.
1 | 2 | 3 | ||
---|---|---|---|---|
1. Submitters should run clang-format before submitting a patch and it should be rejected in gerrit if it’s not formatted properly with an error telling them how to format it. | - | 30 | 33 | |
2. coreboot should stick with manual formatting. | 28 | - | 29 | |
3. Code should just get automatically reformatted on a regular basis. | 17 | 26 | - |
Ballot reporting was not enabled for this poll.
Feel like voting on something else? Try one of these public polls: